test: ensure assertions are reached on all tests - #64716
Merged
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Ethan-Arrowood
approved these changes
Jul 24, 2026
Ethan-Arrowood
left a comment
Ethan-Arrowood
left a comment
Contributor
There was a problem hiding this comment.
Approving but I think you have to fix on test that has a CI failure.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64716 +/- ##
=======================================
Coverage 90.16% 90.16%
=======================================
Files 744 744
Lines 242518 242518
Branches 45692 45705 +13
=======================================
+ Hits 218663 218670 +7
- Misses 15349 15357 +8
+ Partials 8506 8491 -15 🚀 New features to boost your workflow:
|
avivkeller
approved these changes
Jul 24, 2026
bjohansebas
approved these changes
Jul 24, 2026
Collaborator
Collaborator
aduh95
added
the
author ready
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: nodejs#64716 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95
force-pushed
the
enforce-assert-fixtures
branch
from
July 27, 2026 17:04
9ab72df to
6a3d80f
Compare
Contributor
Author
|
Landed in 6a3d80f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A number of tests are escaping the linter rules added in 0457bfe and 634dc26 by destructuring
assertand/orfixtures.